fixing the extension_url with WP core in another directory
#2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, the `extension_url` is not set corretly, when the WordPress core has it's own subfolder such as `wp` which is totally fine and often found when using a Git submodule or composer setup for WordPress which many professional developers use.
Member
|
I don't have a modified WP install to confirm with. |
Contributor
|
Added manually and gave you credit. Moved to a Helper function instead. Will update all of our extensions. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the
extension_urlis not set corretly, when the WordPress core has it's own subfolder such aswpwhich is totally fine and often found when using a Git submodule or composer setup for WordPress which many professional developers use.