Skip to content

Conversation

markerikson
Copy link
Contributor

This PR:

  • Rewrites the per-entry-point initialization of useSyncExternalStore to work regardless of how modules are loaded and initialized

The previous attempt worked fine in local dev + tests, but failed when built and run in a real app.

The previous attempt worked fine in local dev + tests, but failed
when built and run in a real app.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e0c5c3d:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Nov 20, 2021

✔️ Deploy Preview for react-redux-docs ready!

🔨 Explore the source changes: e0c5c3d

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/61984392a240460007e12643

😎 Browse the preview: https://deploy-preview-1845--react-redux-docs.netlify.app

@github-actions
Copy link

Size Change: +123 B (0%)

Total Size: 21.3 kB

Filename Size Change
dist/react-redux.js 16.2 kB +134 B (0%)
dist/react-redux.min.js 5.07 kB -11 B (0%)

compressed-size-action

@markerikson markerikson merged commit 791e009 into master Nov 20, 2021
@markerikson markerikson deleted the feature/fix-v8-module-init branch November 20, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant