Use callback ref instead of string #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good call. I know some people may be relying on exact ref name in their test cases so I’ll probably hold this off until the next major. |
foiseworth
pushed a commit
to foiseworth/react-redux
that referenced
this pull request
Jul 30, 2016
Per reduxjs#345, navigating to a docs page URL that includes a hash anchor causes the page to snap back up to the top. This is due to Gitbook showing the sidebar. The "anker-enable" plugin hacks around that by setting a short timeout on docs page load, and then changing the page location back to the hash URL. This appears to work around the issue.
|
Superseded by #416. (Sorry, JD!) |
|
lol @timdorr, no worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you care about this, but I was browsing the source code and noticed you were still using a string ref. I just updated it to a callback ref.