`upsertQueryEntries` does not create subscriptions and provided tags

[sondreluc]

Hi!

I have tried to utilize the upsertQueryEntries util to populate individual cache entries, similar to the getPosts/getPost example in the docs and v2.3.0 release notes.
This works fine, until I want to perform some optimistic updates on the different entries, as selectInvalidatedBy does not contain the individual entity queries.

I tested with replacing upsertQueryEntries with upsertQueryData, and this seems to work. Inspecting the difference in api state from the two utils, it looks like they both add all the queries to the api state, but upsertQueryData adds subscriptions and provided tags for all the individual entries, while upsertQueryEntries does not.

I have created a codesandbox where you can easily toggle between the to different utils.
Codesandbox: https://codesandbox.io/p/sandbox/agitated-surf-zxvyw5

So now I'm wondering if this is a bug, or intentional behavior and that I will have to resort to upsertQueryData if i want to be able to do optimistic updates on the individual cache entries.

[markerikson]

Hmm. I'd say it's probably more of a bug.

It looks like we currently check for just the thunks to calculate that value:

        .addMatcher(
          isAnyOf(isFulfilled(queryThunk), isRejectedWithValue(queryThunk)),
          (draft, action) => {
            const providedTags = calculateProvidedByThunk(
              action,
              'providesTags',
              definitions,
              assertTagType,
            )

so it may be as simple as adding upsertQueryEntries in there too.

[sondreluc]

Thanks for the quick reply and PR @markerikson!

[markerikson]

@sondreluc could you try out the build from that PR to see if it works for you?

[sondreluc]

@sondreluc could you try out the build from that PR to see if it works for you?

As I commented in the PR, it does work, and fixes my issue with optimistic updates on upserted query entries. 👍
I also added the PR build to the codesandbox, and I see that the tags are correctly create. The subscriptions are not added tho, which is a diverging behavior from upsertQueryData. I don't know if that's still intentional, but it does not impact my use case.

[markerikson]

Out in https://github.com/reduxjs/redux-toolkit/releases/tag/v2.6.1 !