Skip to content

Conversation

e-jigsaw
Copy link
Contributor

Replace process.env.NODE_ENV by adding this config when using browserify.

React also written this config: https://github.com/facebook/react/blob/0ce28c6e88448af6eda69df66088b88e7248bbb7/packages/react/package.json#L29-L33

Thanks

Review on Reviewable

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

Don't we also need to make it a dependency then?

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

Also if we go with that, we need to add this to React Redux as well.

@e-jigsaw
Copy link
Contributor Author

@gaearon

Don't we also need to make it a dependency then?

No, Just "browserify": "..."

Also if we go with that, we need to add this to React Redux as well.

Yes, I will send same PR to react-redux if this PR merged

@timdorr
Copy link
Member

timdorr commented Jan 28, 2016

LGTM and shouldn't hurt anything to add it. 👍

gaearon added a commit that referenced this pull request Jan 28, 2016
@gaearon gaearon merged commit e2baf0c into reduxjs:master Jan 28, 2016
@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

Thanks

@e-jigsaw
Copy link
Contributor Author

@gaearon Thanks, I sent same PR to react-redux.

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

Out in 3.1.0.

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

FYI #1304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants