Skip to content

[WIP] Warn if initial state shape doesn't match reducer name #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] Warn if initial state shape doesn't match reducer name #276

wants to merge 2 commits into from

Conversation

@emmenko
Copy link
Contributor

@emmenko emmenko commented Jul 15, 2015

Refs #272

  • add test to reproduce problem
  • add warning and fix test

gaearon
gaearon reviewed Jul 15, 2015
View reviewed changes
test/createStore.spec.js
Copy link
Contributor

@gaearon gaearon Jul 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think counter and todos would be more inline with the tests we have so far :-)

@gaearon gaearon mentioned this pull request Jul 22, 2015
Closed
13 tasks
@emmenko emmenko mentioned this pull request Jul 23, 2015
Merged
@emmenko
Copy link
Contributor Author

emmenko commented Jul 23, 2015

Done in #302

@emmenko emmenko closed this Jul 23, 2015
@emmenko emmenko deleted the warn-wrong-initialstate-shape branch July 23, 2015 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmenko @gaearon