[todos] [refactor] improve the general style of the approach to React

[raunofreiberg]

Some code clean-up for easier understanding and better conventions (i.e no temporary variable for connecting a component to the store).

[timdorr]

I know this is pedantic, but can we leave this alone? I'd rather make the UI and code 1:1, than essentially be doing meta-programming of the UI.

[raunofreiberg]

Was wondering about this as well. Amended my last commit, should be restored now.

[timdorr]

BTW, any code changes here need to be reflected here: https://github.com/reactjs/redux/blob/master/docs/basics/ExampleTodoList.md

[raunofreiberg]

Seems like the ExampleTodoList.md hasn't been updated for a while. Went ahead and updated the whole readme since the docs were outdated a bit and still used the old style as opposed to the actual code.

[timdorr]

This should still be two spaces. Are you running Prettier locally? We've added it to the library code, but not the examples yet. It may be a good idea to introduce it now, since this is already a pretty notable refactor.

[raunofreiberg]

Hmm. Not sure how that happened, I'm not using Prettier locally either. Maybe consider creating a issue about it separately and it might get taken up in another pull request. Fixed it for now.

[timdorr]

👍

[raunofreiberg]

@timdorr This should be ready for merging now.

[timdorr]

It's got the 👍 from me, but since this is rather large and very visible code, I'd like a second set of eyes on it before merging.

[CodeKommissar]

Hi @timdorr! About the coding style, I think the changes made by @raunofreiberg are for the better. It uses const declarations instead of let, has better naming conventions and the arrow functions implicitly return objects. The refactoring (in my opinion) does improves readability.

[timdorr]

OK, I think we're good on this. Thanks!