Remove validator.js suggestion #2880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah, let's switch out the link instead. xss-filters looks good. |
Author
|
Hey Tim, I've gone ahead and added xss-filters as the suggested sanitization library. Thanks! |
Member
| <script>document.write('Thanks!')</script> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the validator.js documentation, XSS sanitization was removed from the library in late 2013. Because of this, I believe it makes sense to remove it as a suggestion from the SSR recipe. At the time, the maintainer suggested checking out Google Caja. I also did some searching on NPM and found the following two packages, both of which seem full featured and popular:
https://www.npmjs.com/package/xss
https://www.npmjs.com/package/xss-filters
Should we replace the suggestion with one of the alternatives above? Definitely open to suggestions — thanks!