fix: Deduplicate shared types #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying redwood-sdk-docs with
|
| Latest commit: |
d00fc65
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1e35dec0.redwood-sdk-docs.pages.dev |
| Branch Preview URL: | https://fix-duplicate-rw-context-typ.redwood-sdk-docs.pages.dev |
justinvdm
added a commit
that referenced
this pull request
Oct 13, 2025
This change consolidates duplicated types into a single source of truth. The `RwContext`, `DocumentProps`, and `LayoutProps` types were previously defined in both `sdk/src/runtime/lib/router.ts` and `sdk/src/runtime/lib/rwContext.ts`. To resolve this, `sdk/src/runtime/lib/rwContext.ts` has been renamed to `sdk/src/runtime/lib/types.ts` to better reflect its broader content. The duplicate definitions in `sdk/src/runtime/lib/router.ts` have been removed, and all imports now point to the new `types.ts` file.
justinvdm
added a commit
that referenced
this pull request
Oct 13, 2025
We accidentally stopped exporting these types in #815
justinvdm
added a commit
that referenced
this pull request
Oct 23, 2025
We accidentally stopped exporting these types in #815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change consolidates duplicated types into a single source of truth. The
RwContext,DocumentProps, andLayoutPropstypes were previously defined in bothsdk/src/runtime/lib/router.tsandsdk/src/runtime/lib/rwContext.ts.To resolve this,
sdk/src/runtime/lib/rwContext.tshas been renamed tosdk/src/runtime/lib/types.tsto better reflect its broader content. The duplicate definitions insdk/src/runtime/lib/router.tshave been removed, and all imports now point to the newtypes.tsfile.