Fix encoded # in path parameter causes route to be evaluated differently

[dunnai]

#11929

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5cc0999

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot]

Hi @dunnai,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[timdorr]

Can you add a test for this?

[timdorr]

This will always be a string. This test shouldn't be needed.

Suggested change

	href = typeof to === "string" ? href.replace(/#/, "%23") : href
	href = href.replace(/#/, "%23")

[dunnai]

This test fails when href = href.replace(/#/, '%23') is executed.

[jhroemer]

@dunnai @timdorr is there any way I can help on this one?

I assume the issue still persist in v7, but I might be wrong?

[dunnai]

@jhroemer The issue still persists in v7, but merging my code will fix it.

[brophdawg11]

Thank you for the PR - I think it's safest to do this logic higher up so we don't inadvertently encode valid hash characters. I have an updated solution in #14249 that only does this on hashes in the pathname portion of a location.