-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
feat(fs-routes): add nestedRoutes
#12648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Hi @okalil, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you look at also porting over the test from here? https://github.com/remix-run/v1-compat-utils/blob/main/packages/v1-route-convention/__tests__/index-test.ts
|
@okalil any chance for me to help with the changes requested? |
|
Any chance this can get merged? Would be nice for people migrating from Remix that are using Thanks! |
|
any news on this getting merged? Would definitly help a lot in organizing the routes |
c436cc8 to
79a3411
Compare
|
To align with our new Open Governance model, I'm going to close this PR for the time being so we can discuss the feature in the proposal (#12647). If we move forward from there we can re-open this PR at the Alpha stage. |
Closes #12647