Skip to content

Conversation

@okalil
Copy link
Contributor

@okalil okalil commented Dec 27, 2024

Closes #12647

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: c6fc1fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 27, 2024

Hi @okalil,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@okalil okalil changed the base branch from main to dev December 27, 2024 17:32
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 27, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diego-hourly
Copy link

@okalil any chance for me to help with the changes requested?

@bgonzalez-thestable
Copy link

Any chance this can get merged? Would be nice for people migrating from Remix that are using @remix-run/v1-route-convention.

Thanks!

@sirNugg3ts
Copy link

any news on this getting merged? Would definitly help a lot in organizing the routes

@MichaelDeBoey MichaelDeBoey changed the title Fs folders routes feat(fs-routes): add nestedRoutes Jun 30, 2025
@okalil okalil force-pushed the fs-folders-routes branch from c436cc8 to 79a3411 Compare June 30, 2025 18:20
@brophdawg11
Copy link
Contributor

To align with our new Open Governance model, I'm going to close this PR for the time being so we can discuss the feature in the proposal (#12647). If we move forward from there we can re-open this PR at the Alpha stage.

@brophdawg11 brophdawg11 closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants