Skip to content

Conversation

@Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jul 23, 2025

Fixes #14042 by removing the declaration of the ___reactRouterServerStorage___ variable from the global scope in the TypeScript declaration files. If it's desirable for this to exist in the declaration file, then I can explore other options, but it seems like somewhat of a private variable that doesn't need to be in the declaration files.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 23, 2025

Hi @Methuselah96,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2025

🦋 Changeset detected

Latest commit: 007f003

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 23, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@markdalgleish markdalgleish changed the base branch from main to dev July 23, 2025 23:32
@markdalgleish markdalgleish changed the base branch from dev to main July 23, 2025 23:32
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you please update this PR to point to the dev branch?

@MichaelDeBoey MichaelDeBoey changed the title fix: remove dependency on @types/node in declaration files fix(react-router/rsc): remove dependency on @types/node Jul 23, 2025
@Methuselah96 Methuselah96 force-pushed the remove-global-augment branch from ae7d776 to 7e64b28 Compare July 24, 2025 02:40
@Methuselah96 Methuselah96 changed the base branch from main to dev July 24, 2025 02:40
@Methuselah96
Copy link
Contributor Author

Methuselah96 commented Jul 24, 2025

Done, sorry for missing that

@markdalgleish markdalgleish changed the title fix(react-router/rsc): remove dependency on @types/node fix(react-router/rsc): remove dependency on @types/node in TypeScript declaration files Jul 24, 2025
@markdalgleish markdalgleish merged commit 9fde466 into remix-run:dev Jul 24, 2025
5 checks passed
@Methuselah96 Methuselah96 deleted the remove-global-augment branch July 24, 2025 13:18
@Methuselah96
Copy link
Contributor Author

@markdalgleish Any estimate on when this will be released?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

🤖 Hello there,

We just published version 7.8.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

🤖 Hello there,

We just published version 7.8.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript error importing node:async_hooks

3 participants