Fix deprecation warnings for react >= 15.5.0 #4934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a similar PR in #4933 😅 |
|
Oh. It wasn't there when I started :D Well done! |
|
¯\_(ツ)_/¯ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
React.PropTypestoPropTypesfrom theprop-typespackage, regarding the latestreactversion -> https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypesreact-router-reduxandreact-router-websiteare still raising this warning, until the dependencies are fixed too.For redux, the PR is here: reduxjs/react-redux#663
I also updated eslint for the main package in order to took advantage of the new
no-unuser-varsoption, ignorerestsiblings, and allow the omit pattern used like here: https://github.com/Calyhre/react-router/blob/master/packages/react-router/modules/StaticRouter.js#L114