Skip to content

Conversation

@MichaelDeBoey
Copy link
Member

The actual code is doing exactly the same, but is introducing type guards for some extra type-safety inside the code itself.

I took inspiration from how React Router handles this check
https://github.com/remix-run/react-router/blob/87912477ce25a501f8cac71c1105dfe3b0bff5ca/packages/react-router-dev/vite/node-adapter.ts#L53-L55

This check was originally introduced in @TrySound's #10199 and resubmitted in remix-run/react-router#13746

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2025

⚠️ No Changeset found

Latest commit: 38c2f71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mjackson
Copy link
Member

Thanks, @MichaelDeBoey, but I don't think we need this check.

@mjackson mjackson closed this Jul 25, 2025
@MichaelDeBoey MichaelDeBoey deleted the add-type-safety-to-socket-check-in-createRequest branch July 25, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants