Introduce wgpu based re_renderer (experimental!) #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Oct 10, 2022
emilk
reviewed
Oct 10, 2022
jondo2010
reviewed
Oct 11, 2022
Comment on lines
5
to
8
| output_format_color: wgpu::TextureFormat, | ||
| /// The depth format used by the eframe output buffer. | ||
| /// TODO(andreas): Should we maintain depth buffers per view and ask for no depth from eframe? | ||
| output_format_depth: Option<wgpu::TextureFormat>, |
Contributor
There was a problem hiding this comment.
Suggested change
| output_format_color: wgpu::TextureFormat, | |
| /// The depth format used by the eframe output buffer. | |
| /// TODO(andreas): Should we maintain depth buffers per view and ask for no depth from eframe? | |
| output_format_depth: Option<wgpu::TextureFormat>, | |
| color_output_format: wgpu::TextureFormat, | |
| /// The depth format used by the eframe output buffer. | |
| /// TODO(andreas): Should we maintain depth buffers per view and ask for no depth from eframe? | |
| depth_output_format: Option<wgpu::TextureFormat>, |
Member
Author
There was a problem hiding this comment.
starting with output_format is more autocompletion friendly though ;)
jondo2010
reviewed
Oct 11, 2022
emilk
approved these changes
Oct 11, 2022
Member
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Looks good!
…but I left some nits :]
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
Member
Author
|
web glitch fixed in gfx-rs/wgpu#3093 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at a wgpu based re_renderer crate and integration into re_viewer
Renders test triangle successfully on native and browser.
can be tested locally using
cargo run -p rerun --features=wgpu --no-default-features -- ../car.rrd(for web, it's easiest to hack the default feature on re_viewer, no point in streamlining this right now)
There's glitch in the browser right now:
The moment we stop rendering continously, the viewport resizes. Likely an eframe issue, need to investigate. (suspecting that something in the order of callbacks vs primitives causes issue with a viewport not being reset)