expand options in typed expr/pattern completion #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
reviewed
Jan 11, 2023
| "tags": [], | ||
| "detail": "otherRecord", | ||
| "documentation": null, | ||
| "insertText": "Some({$0})", |
There was a problem hiding this comment.
is this intended in addition to the previous completion?
There was a problem hiding this comment.
Yes. Logic being that you might want to do one of three things:
- Add None
- Add Some but with any
- Add Some, plus whatever value for the nested type you're interested in
That's why I'm adding it in addition rather than fully replacing the completions.
cristianoc
approved these changes
Jan 11, 2023
zth
force-pushed
the
expand-options-in-completions
branch
from
80c453a to
96e1db0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a QoL thing to make working with options easier in typed completion, allowing you to skip a step completing inside of
Someand directly have access to the possibleSomevalues.