Skip to content

Make completion engine understand await #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2023
Merged

Make completion engine understand await #813

merged 2 commits into from
Aug 20, 2023

Conversation

zth
Copy link
Member

@zth zth commented Aug 19, 2023

This makes the completion engine understand async/await.

@zth zth requested a review from cristianoc August 19, 2023 19:33
cristianoc
cristianoc approved these changes Aug 20, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be considered an instance of apply but it does not add much complexity so looks good!

@zth zth merged commit f2b4644 into master Aug 20, 2023
@zth zth deleted the complete-await branch August 20, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zth @cristianoc