Dont complete for illegal file module names #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Nov 12, 2023
analysis/src/Utils.ml
Outdated
| if String.length s = 0 then s | ||
| else String.mapi (fun i c -> if i = 0 then Char.lowercase_ascii c else c) s | ||
|
|
||
| let hasUnallowedChars s = |
There was a problem hiding this comment.
Unclear this is about file names by just looking at the code.
zth
force-pushed
the
filter-out-illegal-names
branch
from
8fa57d9 to
7619c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We handled namespace file modules before, but other "exotic" file modules could still appear (example:
SomeTest.test.res) which can't be used anyway. This filters anything with illegal characters in the name, for file modules specifically.