Skip to content

Enhance regexp completion #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2024
Merged

Enhance regexp completion #903

merged 2 commits into from
Jan 29, 2024

Conversation

zth
Copy link
Member

@zth zth commented Jan 28, 2024

This enhances completion where the type is a regexp a bit, by:

  • Preferring Core's RegExp module when Core is opened
  • Adding a %re("") item automatically to the completion list in any place where a regexp value is expected

Small things, but should add some QoL.

@zth zth requested a review from cristianoc January 28, 2024 20:42
cristianoc
cristianoc approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@zth zth merged commit 7d9b33f into master Jan 29, 2024
@zth zth deleted the enhance-completions-in-regexp branch January 29, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zth @cristianoc