Skip to content

Conversation

@DZakh
Copy link
Member

@DZakh DZakh commented Apr 28, 2024

No description provided.

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot! 👍

Not sure if there might be any conflicts with #6102 in the JS output? Let's get that one merged first maybe.

@DZakh
Copy link
Member Author

DZakh commented Apr 28, 2024

It's just a matter of running make test after merging changes. I have another pr prepared, so I'd like to have this merged

@cknitt
Copy link
Member

cknitt commented Apr 28, 2024

Ok, then let's merge this one first (can't wait for the next one 😄).

@cknitt cknitt merged commit 4738476 into rescript-lang:master Apr 28, 2024
@DZakh
Copy link
Member Author

DZakh commented Apr 28, 2024

There is more indent clean up. I'll prepare a pr when I'm back home 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants