Remove a number of ast nodes never populated by the .res parser, and resulting dead code. #6830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat! 😍 I guess this is fully safe wrt the editor tooling etc, because these nodes will never exist? |
That, and the fact that cases are not removed (but kept with a unit payload). Removing them would shift the numbers associated with the runtime representation of the cases following the removed one. |
cknitt
approved these changes
Jun 27, 2024
zth
approved these changes
Jun 27, 2024
Sig and str class type cannot be generated by the .res parser. Remove a bunch of code that deals with that.
… trying to remove it.
cristianoc
force-pushed
the
sig_class_type
branch
from
235081c to
ce4db7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.