Fix async context checking for module await. #7271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
async-context-module
branch
3 times, most recently
from
ed00b7e to
3005e77
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: eccff4f | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.3688083599999998 ms |
1.2123143266666667 ms |
1.13 |
Parse Napkinscript.res - time/run |
42.731040799999995 ms |
39.28006235333333 ms |
1.09 |
Parse HeroGraphic.res - time/run |
5.766649673333333 ms |
5.13472718 ms |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
zth
approved these changes
Feb 1, 2025
cknitt
approved these changes
Feb 1, 2025
The check was not firing for `module M: ModTyp` as it was looking for attributes in the wrong place.
The module constraint can originate from `module M: MT = await N` or from `module M = await (N: MT)` and the attributes go to the module id in the first case, but on the constraint in the second.
cristianoc
force-pushed
the
async-context-module
branch
from
f41106f to
eccff4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check was not firing for
module M: ModTypas it was looking for attributes in the wrong place.