Skip to content

Remove warnings that no longer exist from Bsc_warnings.default_w #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 4, 2025
Merged

Remove warnings that no longer exist from Bsc_warnings.default_w #7413

merged 7 commits into from
May 4, 2025

Conversation

mediremi
Copy link
Member

@mediremi mediremi commented May 1, 2025

Warnings 40, 42 and 61 no longer exist in warnings.mli, so might as well remove them from Bsc_warnings.default_w.

@mediremi mediremi force-pushed the update-default-warnings branch from 52218ee to df89772 Compare May 1, 2025 18:30
@mediremi mediremi mentioned this pull request May 1, 2025
Merged
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 1, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7413

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7413

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7413

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7413

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7413

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7413

commit: 5ec4365

@cknitt cknitt requested a review from fhammerschmidt May 4, 2025 15:37
fhammerschmidt
fhammerschmidt approved these changes May 4, 2025
View reviewed changes
Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fhammerschmidt fhammerschmidt merged commit 135f3b2 into rescript-lang:master May 4, 2025
21 checks passed
@mediremi mediremi deleted the update-default-warnings branch May 24, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mediremi @fhammerschmidt