Skip to content

Fix printer removing private for empty record #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

Fix printer removing private for empty record #7448

merged 3 commits into from
May 9, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 9, 2025

Fixes #7447

@cknitt cknitt requested review from cristianoc and zth May 9, 2025 08:00
@cknitt cknitt changed the title Fix private empty record Fix printer removing private for empty record May 9, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 9, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7448

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7448

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7448

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7448

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7448

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7448

commit: 6606d8b

@cknitt cknitt merged commit 6e7f3d3 into master May 9, 2025
21 checks passed
@cknitt cknitt deleted the fix-private-empty-record branch May 9, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nojaf nojaf nojaf approved these changes

@zth zth Awaiting requested review from zth

@cristianoc cristianoc Awaiting requested review from cristianoc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Formatter removes private for empty record

2 participants

@cknitt @nojaf