Skip to content

Change placement of closing > in JSX #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 29, 2025
Merged

Change placement of closing > in JSX #7803

merged 6 commits into from
Aug 29, 2025
+35 −28

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Aug 25, 2025 •
edited
Loading

Trying out #7802

@nojaf nojaf linked an issue Aug 25, 2025 that may be closed by this pull request
Placement of closing > in JSX #7802
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 25, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7803

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7803

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7803

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7803

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7803

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7803

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7803

commit: a80da02

@nojaf
Copy link
Member Author

nojaf commented Aug 25, 2025

@alex35mil could you give the version above (npm i https://pkg.pr.new/rescript-lang/rescript@7803) a go?

@cknitt
Copy link
Member

cknitt commented Aug 29, 2025

Tested and looks good to me!

@nojaf Can we merge that for today's beta?

@nojaf nojaf marked this pull request as ready for review August 29, 2025 07:03
@nojaf
Copy link
Member Author

nojaf commented Aug 29, 2025

Sure thing

@nojaf nojaf requested a review from cknitt August 29, 2025 08:28
cknitt
cknitt approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@nojaf nojaf merged commit 3d570a2 into rescript-lang:master Aug 29, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cknitt cknitt cknitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Placement of closing > in JSX

2 participants

@nojaf @cknitt