Skip to content

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 24, 2025

  • Make tests fail if there is an error on extraction
  • Fix DataView tests
  • Speed up docstring extraction by directly running native exe (not via node)

Closes #7895

@cknitt cknitt force-pushed the fix-docstring-tests branch from 2709dde to 8813423 Compare September 24, 2025 15:05
DataView.getFloat32(dv, 4, ~littleEndian=true) == 3.14
dv->DataView.setFloat32(0, 3.14)
dv->DataView.setFloat32(4, 3.14, ~littleEndian=true)
// DataView.getFloat32(dv, 0) == 3.14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only approximately equal

@cknitt cknitt marked this pull request as ready for review September 24, 2025 15:21
Copy link

pkg-pr-new bot commented Sep 24, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7923

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7923

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7923

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7923

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7923

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7923

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7923

commit: 8813423

@cknitt cknitt merged commit fbb8a4e into master Sep 24, 2025
25 checks passed
@cknitt cknitt deleted the fix-docstring-tests branch September 24, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc string tests do not fail on syntax error

2 participants