🐛 - copy namespace compiler assets and asts to /lib/bs to fix editor support #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandpeelen
approved these changes
Jun 5, 2024
| // copy the mlmap to the bs build path for editor tooling | ||
| let base_build_path = package.get_build_path() + "/" + &suffix; | ||
| let base_bs_build_path = package.get_bs_build_path() + "/" + &suffix; | ||
| let _ = std::fs::copy( |
There was a problem hiding this comment.
I think it might be time to introduce something like anyhow or another way to do nice error handling - more of a note for the future
There was a problem hiding this comment.
Ah cool anyhow looks nice. This stuff also reminds me to refactor the string based paths to proper paths :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.