feat(react-email): Build preview app and run it built instead of as dev #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmfern
added
the
Package: react-email
🦋 Changeset detectedLatest commit: 98f03ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielmfern
force-pushed
the
feat/publish-built-preview-app
branch
from
88e31c4 to
15b80e0
Compare
gabrielmfern
force-pushed
the
feat/publish-built-preview-app
branch
from
96dac6b to
2699cd9
Compare
gabrielmfern
force-pushed
the
feat/publish-built-preview-app
branch
from
2699cd9 to
53602ef
Compare
gabrielmfern
force-pushed
the
feat/publish-built-preview-app
branch
from
53602ef to
08aea8e
Compare
gabrielmfern
force-pushed
the
feat/publish-built-preview-app
branch
from
08aea8e to
a049d0d
Compare
gabrielmfern
force-pushed
the
feat/publish-built-preview-app
branch
from
4c29569 to
16b9438
Compare
bukinoshita
approved these changes
Aug 21, 2024
vcapretz
reviewed
Aug 21, 2024
vcapretz
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes it so that the
email devcommand runs the preview app asin production in a built format. This makes it so that it is much faster, it also
irons out the different issues that arise from this new way to run the preview app.
This PR still keeps the published source code for the preview app with the purpose
of copying and building it with
email buildstill.One more thing this PR does is add a bit of feedback to the user when running
email devthat I think is particularly prettier.
Alpha, released with the purpose of testing this:
[email protected]