feat: use typescript to ensure there's email or id for contacts.get #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the code for contact's
get
to only allow for one ofemail
orid
in the types, but also leaving it at runtime while we don't have the error on the API.Before this we had both
email
andid
as optional fields that could be paseed ontoget
. Which meant that we had to error when both were missing, which meant things weren't really type-safe and only failed at runtime, instead of when runningtsc
or seeing LSP diagnostics.The types still allow for including both
email
andid
, but only one of them can be truthy (not undefined, or null) at once.