Skip to content

Always stream just the headers for DownloadStreamAsync for best memory utilization #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Always stream just the headers for DownloadStreamAsync for best memory utilization #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/RestSharp/RestClient.Async.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ record InternalResponse(HttpResponseMessage? ResponseMessage, Uri Url, Exception
/// <returns>The downloaded stream.</returns>
[PublicAPI]
public async Task<Stream?> DownloadStreamAsync(RestRequest request, CancellationToken cancellationToken = default) {
// Make sure we only read the headers so we can stream the content body efficiently
request.CompletionOption = HttpCompletionOption.ResponseHeadersRead;
var response = await ExecuteInternal(request, cancellationToken).ConfigureAwait(false);

if (response.Exception != null) {
Expand Down
2 changes: 1 addition & 1 deletion src/RestSharp/RestClientExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ public static async IAsyncEnumerable<T> StreamJsonAsync<T>(
string resource,
[EnumeratorCancellation] CancellationToken cancellationToken
) {
var request = new RestRequest(resource) { CompletionOption = HttpCompletionOption.ResponseHeadersRead };
var request = new RestRequest(resource);

#if NETSTANDARD
using var stream = await client.DownloadStreamAsync(request, cancellationToken).ConfigureAwait(false);
Expand Down