Skip to content

Conversation

@talensjr
Copy link

@talensjr talensjr commented Oct 28, 2022

This PR

Motivation:

  • As I am using a Windows 11 computer as my secondary development machine, I have ran in a problem when installing revieve-web-plugin-4 repository.
    An error pops up during npm i of the previous mentioned repo. It occurs when it reaches this dependency and because of the way we are using it, we need to bundle it on client installation.
    Unfortunately, this does not work at the current stage in native Windows OS, the exact reason of why is beyond my knowledge right now, but is something related to webpack and / or its dependencies.

Solution:

  • There are some solutions to this issue, (that can be discussed if needed) but one of them (and worked great), is to update webpack and webpack-cli to their latest versions (v5.x.x).
  • If this change gets merged, we would need to create a new tag and update the revieve-web-plugin-4 dependency by running this command npm i -S revieve/react-webcam#v6.0.1-revieve.1 (or whatever the new tag name is).

How to test:

  • We can currently test it by running npm i -S revieve/react-webcam#windows-install and should be then installing dependencies and running correctly both in windows and macOS.

Demo:

  • Errors:

error-1

error-2

  • Node version:

node-v

@talensjr talensjr requested a review from beavis October 28, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants