fix: configure runner config per runner name #2891

MasterPtato · 2025-09-09T00:43:09Z

No description provided.

vercel · 2025-09-09T00:43:11Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Error			Sep 16, 2025 9:20am
rivet-site	Ready	Preview	Comment	Sep 16, 2025 9:20am

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-studio	Ignored	Preview		Sep 16, 2025 9:20am

claude · 2025-09-09T00:43:26Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

MasterPtato · 2025-09-09T00:43:33Z

fix: configure runner config per runner name #2891 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

pkg-pr-new · 2025-09-09T00:44:02Z

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2891

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2891

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2891

commit: 7d7900b

claude · 2025-09-09T20:28:02Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

graphite-app · 2025-09-09T20:29:39Z

packages/services/namespace/src/ops/runner_config/upsert.rs

+	let variant_str = serde_json::to_string(&input.config.variant())?;
+	ctx.op(internal::ops::cache::purge_global::Input {
+		base_key: format!("namespace.runner_config.{variant_str}.get_global"),
+		keys: vec![(input.namespace_id, input.name.as_str()).cache_key().into()],


The serialization of input.config.variant() to JSON creates inconsistent cache keys. Since JSON serialization of enums can vary (quotes, formatting), it may not match the string representation used elsewhere in the codebase.

Consider using a deterministic string representation instead:

let variant_str = input.config.variant().to_string();

This approach ensures cache keys remain consistent across the application, preventing unnecessary cache misses and improving cache hit rates.

Suggested change

let variant_str = serde_json::to_string(&input.config.variant())?;

ctx.op(internal::ops::cache::purge_global::Input {

base_key: format!("namespace.runner_config.{variant_str}.get_global"),

keys: vec![(input.namespace_id, input.name.as_str()).cache_key().into()],

let variant_str = input.config.variant().to_string();

ctx.op(internal::ops::cache::purge_global::Input {

base_key: format!("namespace.runner_config.{variant_str}.get_global"),

keys: vec![(input.namespace_id, input.name.as_str()).cache_key().into()],

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

claude · 2025-09-09T20:30:31Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-09T20:30:33Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

graphite-app · 2025-09-09T20:32:01Z

packages/services/pegboard/src/workflows/actor/runtime.rs

+			let for_serverless = txs
+				.exists(
+					&namespace::keys::RunnerConfigByVariantKey::new(
+						namespace_id,
+						namespace::keys::RunnerConfigVariant::Serverless,
+						input.runner_name_selector.clone(),
+					),
+					SERIALIZABLE,
+				)
+				.await?;


Database key construction uses wrong namespace. The code creates a namespace::keys::RunnerConfigByVariantKey but uses it with txs which is in the pegboard subspace, not the namespace subspace. This will cause the key lookup to fail since it's looking in the wrong database subspace.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

claude · 2025-09-11T21:33:39Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-11T21:33:42Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-14T20:01:34Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-14T20:03:26Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-15T16:48:38Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-15T18:05:00Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-15T18:07:37Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-16T08:13:29Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

MasterPtato mentioned this pull request Sep 9, 2025

feat(pegboard): outbound runners #2873

Merged

MasterPtato mentioned this pull request Sep 9, 2025

feat(ns): implement namespace updates, global cache purge #2883

Merged

vercel bot deployed to Preview – rivet-site September 9, 2025 00:45 View deployment

MasterPtato force-pushed the 09-08-fix_configure_runner_config_per_runner_name branch from b3091dc to a5cea8e Compare September 9, 2025 20:27

MasterPtato marked this pull request as ready for review September 9, 2025 20:27

MasterPtato requested a review from NathanFlurry September 9, 2025 20:27

graphite-app bot reviewed Sep 9, 2025

View reviewed changes

MasterPtato force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from c376b93 to 8b5ef7d Compare September 9, 2025 20:30

MasterPtato force-pushed the 09-08-fix_configure_runner_config_per_runner_name branch from a5cea8e to 6b11630 Compare September 9, 2025 20:30

graphite-app bot reviewed Sep 9, 2025

View reviewed changes

vercel bot deployed to Preview – rivet-site September 9, 2025 20:35 View deployment

This was referenced Sep 9, 2025

chore: remove port name #2897

Merged

fix(udb): revamp udb api #2898

Merged

MasterPtato force-pushed the 09-08-fix_configure_runner_config_per_runner_name branch from 6b11630 to 88d706e Compare September 11, 2025 21:33

MasterPtato force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 8b5ef7d to 4976f94 Compare September 11, 2025 21:33

This was referenced Sep 11, 2025

fix(engine/fe): remove addresses #2900

Merged

chore: cleanup, move ee changes #2901

Merged

vercel bot deployed to Preview – rivet-site September 11, 2025 21:45 View deployment

MasterPtato mentioned this pull request Sep 12, 2025

fix(api): fix query serialization for remote req #2909

Merged

MasterPtato force-pushed the 09-08-fix_configure_runner_config_per_runner_name branch from 88d706e to c5ce959 Compare September 13, 2025 01:17

MasterPtato force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 4976f94 to 02c9438 Compare September 13, 2025 01:17

This was referenced Sep 13, 2025

fix(epoxy): fix Any quorum type not reaching any node #2910

Merged

feat(cloud): connect page #2912

Closed

NathanFlurry force-pushed the 09-08-fix_configure_runner_config_per_runner_name branch from c5ce959 to 7679f25 Compare September 14, 2025 20:00

NathanFlurry force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 02c9438 to 21d608d Compare September 14, 2025 20:00

vercel bot had a problem deploying to Preview – rivet-cloud September 14, 2025 20:26 Failure

vercel bot deployed to Preview – rivet-site September 14, 2025 20:28 View deployment

NathanFlurry mentioned this pull request Sep 14, 2025

chore(runner): add alarms api #2919

Merged

jog1t force-pushed the 09-08-fix_configure_runner_config_per_runner_name branch from 7679f25 to c5ce959 Compare September 15, 2025 16:47

jog1t mentioned this pull request Sep 15, 2025

feat(inspector): make inspector compatible with new architecture #2920

Closed

MasterPtato force-pushed the 09-08-fix_configure_runner_config_per_runner_name branch from c5ce959 to 7d7900b Compare September 15, 2025 18:04

MasterPtato force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 02c9438 to 3df4e46 Compare September 15, 2025 18:04

MasterPtato mentioned this pull request Sep 15, 2025

chore: fix api gen #2921

Merged

vercel bot had a problem deploying to Preview – rivet-cloud September 15, 2025 18:34 Failure

vercel bot deployed to Preview – rivet-site September 15, 2025 18:37 View deployment

MasterPtato mentioned this pull request Sep 15, 2025

chore: clean up api-public #2922

Merged

NathanFlurry force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 3df4e46 to 012075b Compare September 16, 2025 08:12

Base automatically changed from 09-08-feat_ns_implement_namespace_updates_global_cache_purge to main September 16, 2025 08:12

fix: configure runner config per runner name

c2c14ae

NathanFlurry force-pushed the 09-08-fix_configure_runner_config_per_runner_name branch from 7d7900b to c2c14ae Compare September 16, 2025 08:13

NathanFlurry merged commit a78e100 into main Sep 16, 2025
4 of 11 checks passed

NathanFlurry deleted the 09-08-fix_configure_runner_config_per_runner_name branch September 16, 2025 08:13

github-actions bot mentioned this pull request Sep 16, 2025

chore(main): release 25.6.1 #2851

Merged

vercel bot had a problem deploying to Preview – rivet-cloud September 16, 2025 09:14 Failure

vercel bot deployed to Preview – rivet-site September 16, 2025 09:20 View deployment

fix: configure runner config per runner name #2891

fix: configure runner config per runner name #2891

Uh oh!

Conversation

MasterPtato commented Sep 9, 2025

Uh oh!

vercel bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

pkg-pr-new bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Sep 9, 2025 •

edited

Loading

claude bot commented Sep 9, 2025 •

edited

Loading

MasterPtato commented Sep 9, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 9, 2025 •

edited

Loading

claude bot commented Sep 9, 2025 •

edited

Loading

claude bot commented Sep 9, 2025 •

edited

Loading

claude bot commented Sep 9, 2025 •

edited

Loading

claude bot commented Sep 11, 2025 •

edited

Loading

claude bot commented Sep 11, 2025 •

edited

Loading

claude bot commented Sep 14, 2025 •

edited

Loading

claude bot commented Sep 14, 2025 •

edited

Loading

claude bot commented Sep 15, 2025 •

edited

Loading

claude bot commented Sep 15, 2025 •

edited

Loading

claude bot commented Sep 15, 2025 •

edited

Loading

claude bot commented Sep 16, 2025 •

edited

Loading