fix: add skeleton (remove blinking) #3145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This was referenced Oct 9, 2025
Closed
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Closed
Graphite Automations"Test" took an action on this PR • (10/09/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
commit: |
jog1t
force-pushed
the
10-09-fix_add_skeleton_remove_blinking_
branch
from
1a30377 to
886835c
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
jog1t
force-pushed
the
10-09-fix_add_skeleton_remove_blinking_
branch
from
886835c to
b37e7ea
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
jog1t
force-pushed
the
10-09-fix_add_skeleton_remove_blinking_
branch
from
b37e7ea to
4d2237e
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
jog1t
force-pushed
the
10-09-fix_add_skeleton_remove_blinking_
branch
from
c203333 to
f2838a1
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This was referenced Oct 13, 2025
Closed
Closed
jog1t
force-pushed
the
10-09-fix_add_skeleton_remove_blinking_
branch
from
f2838a1 to
ec04e22
Compare
jog1t
force-pushed
the
10-09-feat_add_favicon
branch
from
0f577ee to
730ae4e
Compare
This was referenced Oct 13, 2025
Closed
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This was referenced Oct 14, 2025
Closed
jog1t
force-pushed
the
10-09-fix_add_skeleton_remove_blinking_
branch
from
ec04e22 to
ac51843
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
NathanFlurry
approved these changes
Oct 14, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
### TL;DR Created a reusable `PendingRouteLayout` component to standardize loading states across routes. ### What changed? - Extracted the loading skeleton UI from the organization route into a new `PendingRouteLayout` component - Applied this component to multiple routes for consistent loading states: - Organization route - Project route - Namespace route - Updated imports to include `H2` and `Skeleton` components where needed - Made a minor text change in the provider dropdown, changing "Coming soon!" to "Soon!" for Vercel integration ### How to test? 1. Navigate between different routes in the application 2. Verify that loading states appear consistently across: - Organization pages - Project pages - Namespace pages 3. Check that the loading skeleton UI displays correctly with proper spacing and layout ### Why make this change? This change improves code reusability by centralizing the loading UI into a single component rather than duplicating it across multiple routes. It ensures a consistent user experience during loading states throughout the application, making the interface feel more cohesive and polished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Created a reusable
PendingRouteLayoutcomponent to standardize loading states across routes.What changed?
PendingRouteLayoutcomponentH2andSkeletoncomponents where neededHow to test?
Why make this change?
This change improves code reusability by centralizing the loading UI into a single component rather than duplicating it across multiple routes. It ensures a consistent user experience during loading states throughout the application, making the interface feel more cohesive and polished.