chore(core): disable printing endpoint if default server disabled #1338

NathanFlurry · 2025-10-03T18:18:38Z

No description provided.

vercel · 2025-10-03T18:18:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Ready	Preview	Comment	Oct 3, 2025 6:22pm

claude · 2025-10-03T18:18:52Z

Claude finished @NathanFlurry's task —— View job

Pull Request Review

I've reviewed the changes in this PR. Here's my feedback:

Review Tasks

Read and analyze the modified file
Review code quality and best practices
Check for potential bugs or issues
Evaluate performance considerations
Assess security concerns
Review test coverage needs
Provide comprehensive feedback

Summary

This PR adds conditional logic to the welcome message display in the start() method to show "(default server disabled)" when config.disableServer is true, instead of always showing the default endpoint URL.

Code Quality & Best Practices ✅

Good: The change follows the existing code style and patterns
Good: Uses consistent indentation and formatting with the surrounding code
Good: The conditional logic is clear and readable
Good: The message text is descriptive and user-friendly

Potential Issues ✅

No issues found: The change is straightforward and doesn't introduce any bugs
Good: The logic correctly checks config.disableServer before deciding which message to display
Good: Both code paths handle the same functionality (printing endpoint information)

Performance Considerations ✅

Negligible impact: This change only affects console output during startup
Good: No performance implications as it's just a conditional console.log statement

Security Concerns ✅

No security issues: The change only affects welcome message display
Good: No sensitive information is exposed in either message variant

Test Coverage

Observation: This change affects console output during startup, which is typically not unit tested
Suggestion: If there are integration tests that verify startup behavior, consider adding a test case to verify the correct message is displayed when disableServer is true
Note: The logic is simple enough that the risk is minimal even without specific test coverage

Inconsistency Issue ⚠️

Important: I noticed that the startServerless() method (lines 154-263) has similar welcome message logic but was not updated with this change. On line 211, it still always prints:

console.log(`  - Endpoint:     http://127.0.0.1:6420`);

This creates an inconsistency where:

start() method: Shows "(default server disabled)" when server is disabled ✅
startServerless() method: Always shows the endpoint URL ❌

Recommendations

Apply the same fix to startServerless(): Update lines 210-211 in the startServerless() method to include the same conditional logic for consistency.
Consider extraction: Since this logic is now duplicated, consider extracting the endpoint display logic into a helper function to avoid future inconsistencies.

Overall Assessment

This is a good, clean change that improves user experience by providing more accurate information when the server is disabled. The only concern is the inconsistency with the startServerless() method that should be addressed.

Recommendation: Address the inconsistency in startServerless() before merging.

NathanFlurry · 2025-10-03T18:18:59Z

feat(examples): deno counter #1291
chore(core): disable printing endpoint if default server disabled #1338 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

pkg-pr-new · 2025-10-03T18:20:59Z

More templates

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/actor@1338

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/cloudflare-workers@1338

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/core@1338

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/db@1338

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/framework-base@1338

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/next-js@1338

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/react@1338

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivetkit@1338

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/sql-loader@1338

commit: bd96223

claude · 2025-10-03T18:21:12Z

Claude finished @NathanFlurry's task —— View job

Pull Request Review

I've reviewed the changes in this PR. Here's my feedback:

Review Tasks

Read and analyze the modified file
Review code quality and best practices
Check for potential bugs or issues
Evaluate performance considerations
Assess security concerns
Review test coverage needs
Provide comprehensive feedback

Summary

This PR adds conditional logic to the welcome message display in the start() method to show "(default server disabled)" when config.disableServer is true, instead of always showing the default endpoint URL.

Code Quality & Best Practices ✅

Good: The change follows the existing code style and patterns
Good: Uses consistent indentation and formatting with the surrounding code
Good: The conditional logic is clear and readable
Good: The message text is descriptive and user-friendly

Potential Issues ✅

No issues found: The change is straightforward and doesn't introduce any bugs
Good: The logic correctly checks config.disableServer before deciding which message to display
Good: Both code paths handle the same functionality (printing endpoint information)

Performance Considerations ✅

Negligible impact: This change only affects console output during startup
Good: No performance implications as it's just a conditional console.log statement

Security Concerns ✅

No security issues: The change only affects welcome message display
Good: No sensitive information is exposed in either message variant

Test Coverage

Observation: This change affects console output during startup, which is typically not unit tested
Suggestion: If there are integration tests that verify startup behavior, consider adding a test case to verify the correct message is displayed when disableServer is true
Note: The logic is simple enough that the risk is minimal even without specific test coverage

Inconsistency Issue ⚠️

Important: I noticed that the startServerless() method (lines 154-263) has similar welcome message logic but was not updated with this change. On line 211, it still always prints:

console.log(`  - Endpoint:     http://127.0.0.1:6420`);

This creates an inconsistency where:

start() method: Shows "(default server disabled)" when server is disabled ✅
startServerless() method: Always shows the endpoint URL ❌

Recommendations

Apply the same fix to startServerless(): Update lines 210-211 in the startServerless() method to include the same conditional logic for consistency.
Consider extraction: Since this logic is now duplicated, consider extracting the endpoint display logic into a helper function to avoid future inconsistencies.

Overall Assessment

This is a good, clean change that improves user experience by providing more accurate information when the server is disabled. The only concern is the inconsistency with the startServerless() method that should be addressed.

Recommendation: Address the inconsistency in startServerless() before merging.

claude · 2025-10-03T18:21:12Z

Claude finished @NathanFlurry's task —— View job

Pull Request Review

I've reviewed the changes in this PR. Here's my feedback:

Review Tasks

Read and analyze the modified file
Review code quality and best practices
Check for potential bugs or issues
Evaluate performance considerations
Assess security concerns
Review test coverage needs
Provide comprehensive feedback

Summary

This PR adds conditional logic to the welcome message display in the start() method (lines 105-109) to show "(default server disabled)" when config.disableServer is true, instead of always showing the default endpoint URL.

Code Quality & Best Practices ✅

Good: The change follows the existing code style and patterns
Good: Uses consistent indentation and formatting with the surrounding code
Good: The conditional logic is clear and readable
Good: The message text is descriptive and user-friendly

Potential Issues ✅

No issues found: The change is straightforward and doesn't introduce any bugs
Good: The logic correctly checks config.disableServer before deciding which message to display
Good: Both code paths handle the same functionality (printing endpoint information)

Performance Considerations ✅

Negligible impact: This change only affects console output during startup
Good: No performance implications as it's just a conditional console.log statement

Security Concerns ✅

No security issues: The change only affects welcome message display
Good: No sensitive information is exposed in either message variant

Test Coverage

Observation: This change affects console output during startup, which is typically not unit tested
Suggestion: If there are integration tests that verify startup behavior, consider adding a test case to verify the correct message is displayed when disableServer is true
Note: The logic is simple enough that the risk is minimal even without specific test coverage

Inconsistency Issue ⚠️

Important: I noticed that the startServerless() method (lines 154-263) has similar welcome message logic but was not updated with this change. On line 211, it still always prints:

console.log(`  - Endpoint:     http://127.0.0.1:6420`);

This creates an inconsistency where:

start() method: Shows "(default server disabled)" when server is disabled ✅
startServerless() method: Always shows the endpoint URL ❌

Recommendations

Apply the same fix to startServerless(): Update lines 210-211 in the startServerless() method to include the same conditional logic for consistency.
Consider extraction: Since this logic is now duplicated, consider extracting the endpoint display logic into a helper function to avoid future inconsistencies.

Overall Assessment

This is a good, clean change that improves user experience by providing more accurate information when the server is disabled. The only concern is the inconsistency with the startServerless() method that should be addressed.

Recommendation: Address the inconsistency in startServerless() before merging.

graphite-app · 2025-10-03T19:20:30Z

Merge activity

Oct 3, 7:20 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
Oct 3, 7:20 PM UTC: CI is running for this pull request on a draft pull request (#1340) due to your merge queue CI optimization settings.
Oct 3, 7:21 PM UTC: Merged by the Graphite merge queue via draft PR: #1340.

)

chore(core): disable printing endpoint if default server disabled

bd96223

NathanFlurry mentioned this pull request Oct 3, 2025

feat(examples): deno counter #1291

Closed

vercel bot deployed to Preview October 3, 2025 18:20 View deployment

NathanFlurry changed the base branch from 09-22-feat_examples_deno_counter to graphite-base/1338 October 3, 2025 18:20

NathanFlurry force-pushed the 10-03-chore_core_disable_printing_endpoint_if_default_server_disabled branch from 1c49cd6 to bd96223 Compare October 3, 2025 18:20

NathanFlurry force-pushed the graphite-base/1338 branch from 5d2329c to 0d59297 Compare October 3, 2025 18:20

NathanFlurry changed the base branch from graphite-base/1338 to main October 3, 2025 18:21

vercel bot deployed to Preview October 3, 2025 18:22 View deployment

graphite-app bot pushed a commit that referenced this pull request Oct 3, 2025

chore(core): disable printing endpoint if default server disabled (#1338

a8dcbce

)

graphite-app bot closed this Oct 3, 2025

graphite-app bot deleted the 10-03-chore_core_disable_printing_endpoint_if_default_server_disabled branch October 3, 2025 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(core): disable printing endpoint if default server disabled #1338

chore(core): disable printing endpoint if default server disabled #1338

Uh oh!

NathanFlurry commented Oct 3, 2025

Uh oh!

vercel bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

claude bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

NathanFlurry commented Oct 3, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

claude bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

claude bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

chore(core): disable printing endpoint if default server disabled #1338

chore(core): disable printing endpoint if default server disabled #1338

Uh oh!

Conversation

NathanFlurry commented Oct 3, 2025

Uh oh!

vercel bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Review

Review Tasks

Summary

Code Quality & Best Practices ✅

Potential Issues ✅

Performance Considerations ✅

Security Concerns ✅

Test Coverage

Inconsistency Issue ⚠️

Recommendations

Overall Assessment

Uh oh!

NathanFlurry commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

pkg-pr-new bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Review

Review Tasks

Summary

Code Quality & Best Practices ✅

Potential Issues ✅

Performance Considerations ✅

Security Concerns ✅

Test Coverage

Inconsistency Issue ⚠️

Recommendations

Overall Assessment

Uh oh!

claude bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Review

Review Tasks

Summary

Code Quality & Best Practices ✅

Potential Issues ✅

Performance Considerations ✅

Security Concerns ✅

Test Coverage

Inconsistency Issue ⚠️

Recommendations

Overall Assessment

Uh oh!

graphite-app bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

vercel bot commented Oct 3, 2025 •

edited

Loading

claude bot commented Oct 3, 2025 •

edited

Loading

NathanFlurry commented Oct 3, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 3, 2025 •

edited

Loading

claude bot commented Oct 3, 2025 •

edited

Loading

claude bot commented Oct 3, 2025 •

edited

Loading

graphite-app bot commented Oct 3, 2025 •

edited

Loading