-
Notifications
You must be signed in to change notification settings - Fork 41
chore(core): add build:fast
script
#1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): add build:fast
script
#1355
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Claude finished @NathanFlurry's task —— View job PR Review: Add
|
More templates
@rivetkit/actor
@rivetkit/cloudflare-workers
@rivetkit/core
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
commit: |
fe373b9
to
99248b3
Compare
6c3e109
to
4fcc430
Compare
Claude finished @NathanFlurry's task —— View job Reviewing PR: Add Todo List:
Code Review FeedbackThis PR introduces a ✅ Strengths
🔧 Code Qualitytsup.base.ts:3: Clean environment variable reading pattern const FAST_BUILD = process.env.FAST_BUILD === "1"; tsup.base.ts:12-19: Good conditional logic for DTS generation with proper TypeScript configuration when enabled Turbo Configuration: Properly declares 🚀 Performance Considerations
🔒 Security Assessment
🧪 Test Coverage
📝 Minor Suggestions
🎯 Recommendations
✅ Overall AssessmentThis is a well-implemented feature that addresses a real developer experience pain point. The code is clean, follows established patterns, and maintains build quality while improving development iteration speed. No blocking issues identified. Approval Status: ✅ Ready to merge (pending any CI checks) |
Claude finished @NathanFlurry's task —— View job Claude finished @NathanFlurry's task —— View job PR Review: Add
|
Merge activity
|
No description provided.