[1.8.12] Validation error regressions

[swalkinshaw]

It looks like the new error bubbling feature introduced in #2013 (and in 1.8.12) causes some regressions in validation errors even when its not enabled (I tried enabling/disabling to be sure).

Here's an example:

1.8.10:

=> {:errors=>
  [{:message=>"Argument 'input' on Field 'productCreate' has an invalid value. Expected type 'ProductInput!'.",
    :locations=>[{:line=>2, :column=>3}],
    :fields=>["mutation M", "productCreate", "input"]}]}

1.8.12 error_bubbling = false

{:errors=>
  [{:message=>"Argument 'foo' on InputObject 'ProductInput' is required. Expected type FooInput!", :locations=>[{:line=>2, :column=>52}], :fields=>["mutation M", "productCreate", "input", "foo"]},
   {:message=>"Argument 'bar' on InputObject 'ProductInput' is required. Expected type BarInput!",
    :locations=>[{:line=>2, :column=>52}],
    :fields=>["mutation M", "productCreate", "input", "bar"]}]}

1.8.12 error_bubbling = true

{:errors=>
  [{:message=>"Argument 'input' on Field 'productCreate' has an invalid value. Expected type 'ProductInput!'.",
    :locations=>[{:line=>2, :column=>3}],
    :fields=>["mutation M", "productCreate", "input"]},
  [{:message=>"Argument 'foo' on InputObject 'ProductInput' is required. Expected type FooInput!", :locations=>[{:line=>2, :column=>52}], :fields=>["mutation M", "productCreate", "input", "foo"]},
   {:message=>"Argument 'bar' on InputObject 'ProductInput' is required. Expected type BarInput!",
    :locations=>[{:line=>2, :column=>52}],
    :fields=>["mutation M", "productCreate", "input", "bar"]}]}

cc @modosc as well

[modosc]

i don't think this is the error bubbling but rather the fix for #1967 - if i'm seeing this right you're now getting the individual errors for the missing fields (which wasn't available before). the error bubbling functionality seems to be working as your third example has all three errors (the two actual missing errors as well as the parent input object). i didn't gate this fix off of error bubbling because it seemed unrelated, it was something that should have existed previously but didn't.

[rmosolgo]

Oh, I see now what you mean, how the old behavior was a third thing where the parent error was present (on productCreate(input: ...)), but now the underlying errors on productCreate(input: { foo: ..., bar: ...}) are present instead.

I guess I think of this as a feature, since it gives clients more information about what went wrong. Is this a regression beyond the fact that it's different than before? I mean, are there downsides besides being not-the-same?

[swalkinshaw]

I guess I think of this as a feature, since it gives clients more information about what went wrong. Is this a regression beyond the fact that it's different than before? I mean, are there downsides besides being not-the-same?

Yeah correct. I meant regression as "unexpected change". I'm not sure this issues required any changes/action, but thought it would be useful for documentation purposes.

[modosc]

maybe we could add a changelog entry for this specific fix? it was merged in with the error bubbling but it's really a separate thing.

[swalkinshaw]

That would probably be useful 👍

[rmosolgo]

I added a changelog entry: https://github.com/rmosolgo/graphql-ruby/blob/master/CHANGELOG.md#1812-3-jan-2018 Feel free to PR if you'd like to improve it!