Skip to content

Conversation

asgeroverby
Copy link
Contributor

Minimal support for Python 3.

All tests pass with:

Robot Framework 3.0 (Python 2.7.5 on win32)
Robot Framework 3.0 (Python 3.4.3 on win32)

Note: I think the notice on Python 3 in QuickStart.rst should be updated if this pull request is accepted.

sut/login.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is list really needed here?

@pekkaklarck
Copy link
Member

Good idea! Please look at the notes I added, tough. It would probably be a good idea to add from __future__ import print_function to files using print too.

It's a good idea also to mention in that the guide supports Python 3. Should it be mentioned both in README.rst and in QuickStartGuide.rst? Could you add such notes too?

@asgeroverby
Copy link
Contributor Author

Your suggestions have been implemented. Notes on Python 3 have been added / updated too.

@pekkaklarck
Copy link
Member

Great! In a bigger project (e.g. Robot Framework) I would still ask you to squash commits, but I don't think that's really needed here. I also noticed on small typo but can easily fix it myself.

pekkaklarck added a commit that referenced this pull request Jan 27, 2016
@pekkaklarck pekkaklarck merged commit 56bcf7d into robotframework:master Jan 27, 2016
@pekkaklarck
Copy link
Member

Thanks again for the PR. Decided to create a new release with it: https://github.com/robotframework/QuickStartGuide/releases/tag/1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants