Skip to content

Conversation

@mklilley
Copy link
Contributor

@mklilley mklilley commented Mar 4, 2021

Currently, draft and non-draft PRs will get the same commit message 'Create draft PR'. This commit fixes that so that non-draft PRs get the message 'Create PR'.

I've not been able to test this code but I thought it was better to write some code instead of asking you to write the code for me :-)

Currently, draft and non-draft PRs will get the same commit message 'Create draft PR'. This commit fixes that so that non-draft PRs get the message 'Create PR'
@mklilley
Copy link
Contributor Author

mklilley commented Mar 4, 2021

Looks like the code that I added needs refactoring but not sure how though.

@robvanderleek
Copy link
Owner

Hi @mklilley

Thanks a lot for your contribution!

Your code looks fine to me 😄 , the createPR function was already a bit long to start with, I'll refactor it another time.
I've extended a unit-test a bit to cover your changes.

Best regards, Rob

@robvanderleek robvanderleek merged commit a366295 into robvanderleek:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants