Skip to content

Conversation

@hahnjo
Copy link
Member

@hahnjo hahnjo commented Jan 23, 2024

The goal of the class is to be an (almost) drop in replacement for SmallVector and std::vector when those are presized and filled later, as it happens in SourceManager and ASTReader.

By doing so, sparsely accessed PagedVector can profit from reduced memory footprint.

Co-authored-by: Jonas Hahnfeld [email protected]

(cherry picked from commit 9c7bac0, backport of #13808)

The goal of the class is to be an (almost) drop in replacement for
SmallVector and std::vector when those are presized and filled later, as
it happens in SourceManager and ASTReader.

By doing so, sparsely accessed PagedVector can profit from reduced
memory footprint.

Co-authored-by: Jonas Hahnfeld <[email protected]>

(cherry picked from commit 9c7bac0)
@hahnjo hahnjo added pr:backport clean build Ask CI to do non-incremental build on PR labels Jan 23, 2024
@hahnjo hahnjo self-assigned this Jan 23, 2024
@hahnjo hahnjo requested a review from vgvassilev as a code owner January 23, 2024 15:09
@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Test Results

     9 files       9 suites   1d 10h 28m 33s ⏱️
 2 481 tests  2 480 ✅ 0 💤 1 ❌
21 361 runs  21 360 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 18014b8.

@dpiparo
Copy link
Member

dpiparo commented Jan 23, 2024

Thanks @hahnjo . On Windows, we see an issue with lexing, but I guess this is caused by #14374, right @bellenot ?

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. For me the PR is ready to be merged if it is confirmed that the failure on Windows is unrelated.

@hahnjo
Copy link
Member Author

hahnjo commented Jan 24, 2024

On Windows, we see an issue with lexing, but I guess this is caused by #14374, right @bellenot ?

Yes, very likely the same as #14200 (comment) on master...

@bellenot
Copy link
Member

On Windows, we see an issue with lexing, but I guess this is caused by #14374, right @bellenot ?

Yes, very likely the same as #14200 (comment) on master...

Right, tutorial-multicore-imt101_parTreeProcessing is currently broken on Windows

@dpiparo dpiparo merged commit bbfce2a into root-project:v6-30-00-patches Jan 24, 2024
@hahnjo hahnjo deleted the paged-vector-v630 branch January 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR pr:backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants