Skip to content

Conversation

jblomer
Copy link
Contributor

@jblomer jblomer commented Sep 24, 2025

Conversion between std::unique_ptr<T> and std::optional<T> as well as T --> std::unique_ptr|std::optional<T>.

Copy link

github-actions bot commented Sep 24, 2025

Test Results

    21 files      21 suites   3d 18h 15m 27s ⏱️
 3 688 tests  3 687 ✅ 0 💤 1 ❌
75 579 runs  75 578 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit ef745c6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@enirolf enirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have two minor documentation suggestions and a question, see below.

@jblomer jblomer force-pushed the ntuple-evolution-nullable branch from 4808ccf to edc8d6d Compare September 27, 2025 21:18
@jblomer jblomer force-pushed the ntuple-evolution-nullable branch from edc8d6d to 5936f59 Compare October 6, 2025 14:17
@jblomer jblomer requested review from enirolf and silverweed October 6, 2025 14:26
@jblomer jblomer force-pushed the ntuple-evolution-nullable branch from 5936f59 to fc079c2 Compare October 7, 2025 21:09
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jblomer jblomer force-pushed the ntuple-evolution-nullable branch from fc079c2 to fcb5647 Compare October 8, 2025 09:21
@jblomer jblomer force-pushed the ntuple-evolution-nullable branch from fcb5647 to ef745c6 Compare October 8, 2025 10:32
@jblomer jblomer merged commit d3767a4 into root-project:master Oct 8, 2025
24 of 27 checks passed
@jblomer jblomer deleted the ntuple-evolution-nullable branch October 8, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants