-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple] automatic evolution of nullable fields #19966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ntuple] automatic evolution of nullable fields #19966
Conversation
Test Results 21 files 21 suites 3d 18h 15m 27s ⏱️ For more details on these failures, see this check. Results for commit ef745c6. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I have two minor documentation suggestions and a question, see below.
4808ccf
to
edc8d6d
Compare
edc8d6d
to
5936f59
Compare
5936f59
to
fc079c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fc079c2
to
fcb5647
Compare
fcb5647
to
ef745c6
Compare
Conversion between
std::unique_ptr<T>
andstd::optional<T>
as well asT
-->std::unique_ptr|std::optional<T>
.