Ensure zero initialization of PosVelAccState::time_from_start #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a very specific setup using joint_trajectory_controller, I started to get strange random crashes with:
Digging a bit, it seems that the program terminates here because of an uninitialized
PosVelAccState::time_from_start
.Further digging showed that the problematic state had been default constructed here, and checking the default constructor I can see that
time_from_start
is never initialized.This seems to fix the problem for me, although it's difficult to confirm because the error is hard to reproduce reliably.