Override get_rcl_allocator for TLSF allocators. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes one more user of the broken generic version of get_rcl_allocator, which is causing ros2/rclcpp#1254. Signed-off-by: Steve Wolter <[email protected]>
wjwwood
reviewed
Oct 26, 2020
Signed-off-by: Steve Wolter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one more user of the broken generic version of
get_rcl_allocator, which is causing
ros2/rclcpp#1254. This is a companion change to ros2/rclcpp#1324.
While there, fix the copy constructor for tslf_heap_allocator. Right now, the allocator keeps an owning ref to a memory pool, and the copy constructor makes a shallow copy of the reference. The first copy of the allocator to go out of scope will invalidate all copies. Instead, use a shared_ptr so that the last copy will clean up the memory pool.
Signed-off-by: Steve Wolter [email protected]