Provides WebSocket Headers Settings #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
requested changes
Jul 23, 2020
Member
OlegDokuka
left a comment
OlegDokuka
left a comment
There was a problem hiding this comment.
LGTM. Few minor changes requested
| { | ||
| socket.Options.SetRequestHeader(key, headers[key]); | ||
| } | ||
| socket.Options.KeepAliveInterval = new TimeSpan(1, 1, 1); |
Member
There was a problem hiding this comment.
should not be included in the PR since it is unrelated
| socket.Options.SetRequestHeader(key, headers[key]); | ||
| } | ||
| socket.Options.KeepAliveInterval = new TimeSpan(1, 1, 1); | ||
| try |
Member
There was a problem hiding this comment.
should not be wrapped in try-catch since the exception is swallowed silently
OlegDokuka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iare trying to make wss connection using rsocket but couldnt find api to set the headers in the transport layer similar to java client transport layer. Hence I made changes in the WebsocketTransport layer to set the headers to ClientWebSocketOptions and able to communicate successfully.