feat: implemented cancel frame handling #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client will send a CANCEL frame for a dropped stream when the next payload is received for this stream.
yuriykulikov
commented
Aug 31, 2021
|
@yuriykulikov Thanks for your hard work! 👍 |
|
@jjeffcaii thank you for a prompt review! I will be happy to make more contributions if I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes Support CANCEL Frames for Request-Stream #48
Client will send a CANCEL frame for a dropped stream when the next payload is received for this stream and the server will inform the RSocket implementation that the stream is closed.
Motivation:
Closing the streams upon reception of a CANCEL frame allows to free up the resources (for example memory allocated for buffers).
Modifications:
For the client: in on_payload() check is_closed() and send CANCEL Frame if downstream is closed.
For the server: Streams returned by the RSocket implementation are wrapped in Aborable. When the CANCEL Frame is received, this Abortable is aborted.
Result:
CANCEL frames are send by the client and handled by the server.