Skip to content

Conversation

@mehagar
Copy link
Contributor

@mehagar mehagar commented Aug 1, 2020

No description provided.

@mehagar mehagar marked this pull request as ready for review August 1, 2020 19:26
@JonRowe
Copy link
Member

JonRowe commented Aug 1, 2020

👋 Thanks for spotting this, but I'm not sure this is anymore valid? The feature file is matchers/new_record_matcher

@mehagar
Copy link
Contributor Author

mehagar commented Aug 1, 2020

I wasn't sure whether the hyperlink should be based on the feature file, since I found it through the Cucumber docs and the url for that is https://relishapp.com/rspec/rspec-rails/v/4-0/docs/matchers/be-a-new-matcher

@JonRowe JonRowe changed the base branch from master to main August 2, 2020 02:13
@JonRowe JonRowe merged commit 067b571 into rspec:main Aug 3, 2020
@JonRowe
Copy link
Member

JonRowe commented Aug 3, 2020

Huh, yeah ok, seems to work! Thank you!

JonRowe added a commit that referenced this pull request Dec 26, 2020
Fix link in docs for be_a_new_matcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants