Fix small issues with translatable strings #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "Enable/Disable" logging description string to make it easier to translate
Fix "Posted date/time" string to make it comply with translatable strings best practices
Fix placeholders on translatable strings to make it comply with best practices
Add a Filter to allow modifying the cache path for Nginx [Master]
…ster Update documentation to specify URL structure needed in Nginx config[Master]
|
Hi @webdados, Thanks for your contribution! The PR looks good to be merged. Could you please fix the merge conflicts so we can proceed with merging and include this in the next release? Also, please make sure to follow the process outlined in the Development.MD file. Let me know if you need any assistance with resolving the conflicts. Thanks! |
|
I'm rebasing the PR to the develop branch according to our development guidelines. Since all PRs need to be tested before merging to master, we should target develop first. I'll raise another PR to add the props 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #348