🔥 Use psych (>= 5.2.5) for encoding Data objects #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
drop-data_lite-yaml-encoding
branch
from
787394a to
19998e1
Compare
|
@eregon It looks like TruffleRuby doesn't like the I guess TruffleRuby will either need to support a compatible |
Merged
This _is_ a breaking change, because objects that would previously encode with a `ruby/object:Net::IMAP:DataSubclass` tag will instead encode with a `ruby/data:Net::IMAP:DataSubclass` tag. Any YAML with the old tag will create an (effectively) empty data object: the data members will not be initialized (but ivars will be set).
|
Could you file an issue at https://github.com/truffleruby/truffleruby/issues ? |
nevans
force-pushed
the
drop-data_lite-yaml-encoding
branch
from
19998e1 to
b43d315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #541, which drops the
Datapolyfill.Unlike #541, this is a breaking change, because objects that would previously encode with a
ruby/object:Net::IMAP:DataSubclasstag will instead encode with aruby/data:Net::IMAP:DataSubclasstag. Any YAML with the old tag will create an (effectively) empty data object: the data members will not be initialized (but ivars will be set).