Skip to content

Implement Pathname#chdir #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement Pathname#chdir #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ext/pathname/pathname.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ static ID id_binwrite;
static ID id_birthtime;
static ID id_blockdev_p;
static ID id_chardev_p;
static ID id_chdir;
static ID id_chmod;
static ID id_chown;
static ID id_ctime;
Expand Down Expand Up @@ -1248,6 +1249,24 @@ path_opendir(VALUE self)
return rb_block_call(rb_cDir, id_open, 1, args, 0, 0);
}

/*
* Changes the current path to the referenced directory.
*
* See Dir.chdir.
*/
static VALUE
path_chdir(VALUE self)
{
VALUE args[1];

if (rb_block_given_p()) {
args[0] = get_strpath(self);
return rb_block_call(rb_cDir, id_chdir, 1, args, 0, 0);
} else {
return rb_funcall(rb_cDir, id_chdir, 1, get_strpath(self));
}
}

static VALUE
each_entry_i(RB_BLOCK_CALL_FUNC_ARGLIST(elt, klass))
{
Expand Down Expand Up @@ -1470,6 +1489,7 @@ path_f_pathname(VALUE self, VALUE str)
* - #each_entry(&block)
* - #mkdir(*args)
* - #opendir(*args)
* - #chdir(*args)
*
* === IO
*
Expand Down Expand Up @@ -1589,6 +1609,7 @@ Init_pathname(void)
rb_define_method(rb_cPathname, "mkdir", path_mkdir, -1);
rb_define_method(rb_cPathname, "rmdir", path_rmdir, 0);
rb_define_method(rb_cPathname, "opendir", path_opendir, 0);
rb_define_method(rb_cPathname, "chdir", path_chdir, 0);
rb_define_method(rb_cPathname, "each_entry", path_each_entry, 0);
rb_define_method(rb_cPathname, "unlink", path_unlink, 0);
rb_define_method(rb_cPathname, "delete", path_unlink, 0);
Expand All @@ -1611,6 +1632,7 @@ InitVM_pathname(void)
id_birthtime = rb_intern("birthtime");
id_blockdev_p = rb_intern("blockdev?");
id_chardev_p = rb_intern("chardev?");
id_chdir = rb_intern("chdir");
id_chmod = rb_intern("chmod");
id_chown = rb_intern("chown");
id_ctime = rb_intern("ctime");
Expand Down
13 changes: 13 additions & 0 deletions test/pathname/test_pathname.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,6 +1416,19 @@ def test_opendir
}
end

def test_chdir
with_tmpchdir('rubytest-pathname') {|dir|
prev = Dir.pwd
Pathname("foo").mkdir
Pathname("foo").chdir
assert_equal("#{prev}/foo", Dir.pwd)
Pathname("..").chdir do
assert_equal(prev, Dir.pwd)
end
assert_equal("#{prev}/foo", Dir.pwd)
}
end

def test_find
with_tmpchdir('rubytest-pathname') {|dir|
open("a", "w") {}
Expand Down