Skip to content

Get rid of Kernel#open #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Get rid of Kernel#open #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc56f6d
Get rid of `Kernel#open`
nobu Oct 29, 2023
7696a57
Stop on truffleruby-head failures
nobu Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ jobs:
run: bundle exec rake
env:
RUBYOPT: --enable-frozen_string_literal
continue-on-error: ${{ matrix.ruby == 'truffleruby-head' }}
- if: ${{ matrix.ruby == 'head' && startsWith(matrix.os, 'ubuntu') }}
run: bundle exec rake rdoc
- if: ${{ matrix.ruby == 'head' && startsWith(matrix.os, 'ubuntu') }}
run: bundle exec rake rubocop

2 changes: 1 addition & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ parsed_files = PARSER_FILES.map do |parser_file|
racc = Gem.bin_path 'racc', 'racc'
rb_file = parser_file.gsub(/\.ry\z/, ".rb")
ruby "#{racc} -l -E -o #{rb_file} #{parser_file}"
open(rb_file, 'r+') do |f|
File.open(rb_file, 'r+') do |f|
newtext = "# frozen_string_literal: true\n#{f.read}"
f.rewind
f.write newtext
Expand Down
14 changes: 2 additions & 12 deletions test/rdoc/test_rdoc_rdoc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,7 @@ def test_normalized_file_list_with_dot_doc
b = Dir.glob(b).first
c = Dir.glob(c).first

dot_doc = File.expand_path('.document')
FileUtils.touch dot_doc
open(dot_doc, 'w') do |f|
f.puts 'a.rb'
f.puts 'b.rb'
end
File.write('.document', "a.rb\n""b.rb\n")
expected_files << a
expected_files << b

Expand All @@ -196,12 +191,7 @@ def test_normalized_file_list_with_dot_doc_overridden_by_exclude_option
b = Dir.glob(b).first
c = Dir.glob(c).first

dot_doc = File.expand_path('.document')
FileUtils.touch dot_doc
open(dot_doc, 'w') do |f|
f.puts 'a.rb'
f.puts 'b.rb'
end
File.write('.document', "a.rb\n""b.rb\n")
expected_files << a

@rdoc.options.exclude = Regexp.new(['b.rb'].join('|'))
Expand Down