Fix to use KeyboardEvent.key over keyCode #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nobu merged 1 commit into ruby:master from gemmaro:fix/keyCode

Jul 5, 2023

Contributor

gemmaro commented Jan 5, 2023 •

edited

Loading

KeyboardEvent.keyCode is deprecated, so this replaces them with KeyboardEvent.key.


          Fix to use KeyboardEvent.key over keyCode

2fa89b3

Member

nobu commented Jul 5, 2023

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key#browser_compatibility

nobu approved these changes

View reviewed changes

nobu merged commit 663edc8 into ruby:master

gemmaro deleted the fix/keyCode branch

July 5, 2023 12:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet